Register modules after app initialization #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mamhoff
force-pushed
the
register-modules-after-app-initialization
branch
3 times, most recently
from
086d028 to
59692df
Compare
If we do this earlier, Zeitwerk will autoload files from other engines. This, in turn, leads to configuration from the local app's `config/initializers` directory not being respected when loading files from those other engines. Case in point: When configuring Solidus' order state machine in Solidus 2.11 using `Spree::Config.state_machines.order = "MyOrderStateMachineModule"`, and this change is not in the gem, Solidus' `Spree::Order` class is loaded, and the wrong module is included.
mamhoff
force-pushed
the
register-modules-after-app-initialization
branch
from
59692df to
516aa3d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we do this earlier, Zeitwerk will autoload files from other engines.
This, in turn, leads to configuration from the local app's
config/initializersdirectory not being respected when loading filesfrom those other engines.
Case in point: When configuring Solidus' order state machine in Solidus
2.11 using
Spree::Config.state_machines.order = "MyOrderStateMachineModule", and this change is not in the gem,Solidus'
Spree::Orderclass is loaded, and the wrong module isincluded.